Native: Application Settings & Refactor Tab Management in Host#2557
Merged
Conversation
* Add settings for checking for updates * Settings added in storage service & state * Setting tab in UI * Refactor + Fixes in code and prepare for the bigger upcoming refactoring in Host
* Move tabs from host state into host tabs struct * The tabs will hold the content of each tab themselves without the need to extra maps or keeping track on stale UI structs * Cleanup the code and remove code smells * Fix stale request IDs on plugins manager as the struct doesn't live forever anymore.
Select the next tab on to the right on active tab is closed instead of selecting home tab blindly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes: