Fix/unexported syncadapter services - #300
Open
PrivateBasicsApp wants to merge 10 commits into
Open
Conversation
…ity-sensitive and AndroidX dependencies
Update/deps and toolchain
…d-window-leaks Fix/service connection and window leaks
Align native libraries for 16 KB page size
They were exported by inheritance from DAVdroid, which let any local app bind them and crash the sync process with a malformed transaction (NPE in AbstractThreadedSyncAdapter.handleOnUnsyncableAccount). The system server binds them either way, since it is exempt from the exported check. Fixes etesync#295.
Author
|
Only the last commit is for the fix; the others were fixes (security/bug) that I was already making on my fork. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #295
Stop exporting the sync adapter services
They were exported by inheritance from DAVdroid, which let any local app bind them and crash the sync process with a malformed transaction (NPE in AbstractThreadedSyncAdapter.handleOnUnsyncableAccount). The system server binds them either way, since it is exempt from the exported check.