ci: install Node 22 + trigger release after Dependabot Automerge#107
Merged
JohnMcLear merged 1 commit intomainfrom May 3, 2026
Merged
ci: install Node 22 + trigger release after Dependabot Automerge#107JohnMcLear merged 1 commit intomainfrom
JohnMcLear merged 1 commit intomainfrom
Conversation
Two unrelated CI bugs landing together because they were blocking the
same job graph:
1. backend-tests.yml and frontend-tests.yml were running on the
default ubuntu-latest Node (currently 20.20), but Etherpad core's
bin/installDeps.sh requires Node 22+:
ERROR: Your nodejs version "20.20" is too old. nodejs 22.0.x or higher is required.
Add `actions/setup-node@v4` with `node-version: 22` to both jobs.
2. The release job (test-and-release.yml) wasn't firing after
Dependabot auto-merges. GitHub suppresses on:push triggers when the
push is authored by GITHUB_TOKEN (which is automerge-action's only
available identity), so merged Dependabot PRs landed on main but
nothing published to npm.
Fix mirrors what shipped to the rest of the ether/* plugins:
- automerge.yml gets `actions: write` permission and a
`gh workflow run test-and-release.yml --ref <default branch>`
step gated on `mergeResult == 'merged'` (so we don't dispatch a
phantom release on every Dependabot Automerge invocation).
- test-and-release.yml gains a `workflow_dispatch:` trigger so
`gh workflow run` is allowed to fire it.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
ⓘ You've reached your Qodo monthly free-tier limit. Reviews pause until next month — upgrade your plan to continue now, or link your paid account if you already have one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two unrelated CI bugs that were blocking the same
test-and-release.ymljob graph:Node 22 in backend + frontend test jobs. Both workflows were running on the runner image's default Node (20.20), but Etherpad core's
bin/installDeps.shrequires Node 22+ — last main run fails with:Add
actions/setup-node@v4withnode-version: 22to both jobs.Auto-publish after Dependabot merges. GitHub suppresses
on:pushtriggers when the push is authored byGITHUB_TOKEN(the automerge-action's only available identity), so merged Dependabot PRs landed on main without ever firing the release job. Fix mirrors what's shipped across the rest of the ether/* plugins:automerge.ymlgetsactions: writeand a post-mergegh workflow run test-and-release.yml --ref <default branch>step, gated onmergeResult == 'merged'.test-and-release.ymlgains aworkflow_dispatch:trigger sogh workflow runis permitted.A previous attempt at #2 (branch
fix/automerge-trigger-release, run 25259365984) failed because Node 22 wasn't installed yet — bundling both fixes here unblocks both.Test plan