Skip to content

feat(upload): auto-detect file content-type if not sent#5361

Open
akrem-chabchoub wants to merge 8 commits intomasterfrom
fix/content-type
Open

feat(upload): auto-detect file content-type if not sent#5361
akrem-chabchoub wants to merge 8 commits intomasterfrom
fix/content-type

Conversation

@akrem-chabchoub
Copy link
Copy Markdown
Contributor

@akrem-chabchoub akrem-chabchoub commented Feb 12, 2026 •
edited
Loading

Checklist

  • I have read the coding guide.
  • My change requires a documentation update, and I have done it.
  • I have added tests to cover my changes.
  • I have filled out the description and linked the related issues.

Description

For single-file POST /bzz, Content-Type is optional: if the client sends it, we keep it exactly, if not we infer it from the first bytes of the body.

Open API Spec Version Changes (if applicable)

Motivation and Context (Optional)

Related Issue (Optional)

#5346

Screenshots (if appropriate):

@akrem-chabchoub akrem-chabchoub self-assigned this Mar 5, 2026
@akrem-chabchoub akrem-chabchoub added this to the 2026 milestone Mar 5, 2026
@acud
Copy link
Copy Markdown
Contributor

acud commented Mar 30, 2026

what is the status of this PR?

@akrem-chabchoub
Copy link
Copy Markdown
Contributor Author

akrem-chabchoub commented Mar 30, 2026

Still not fully tested yet.
Currently on hold due to other priorities.
Work is expected to resume asap.

@akrem-chabchoub akrem-chabchoub added the on hold Temporarily halted by other development label Mar 30, 2026
@akrem-chabchoub akrem-chabchoub removed the on hold Temporarily halted by other development label Apr 9, 2026
@akrem-chabchoub akrem-chabchoub linked an issue Apr 9, 2026 that may be closed by this pull request
File upload: auto-detect content type instead of trusting user header #5346
Open
@akrem-chabchoub akrem-chabchoub marked this pull request as ready for review April 9, 2026 11:21
@akrem-chabchoub akrem-chabchoub changed the title fix(api): enhance content type handling in bzzUploadHandler for direc… feat(upload): auto-detect file content-type if not sent Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@janos janos Awaiting requested review from janos

@martinconic martinconic Awaiting requested review from martinconic

@acud acud Awaiting requested review from acud

@gacevicljubisa gacevicljubisa Awaiting requested review from gacevicljubisa

@sbackend123 sbackend123 Awaiting requested review from sbackend123

At least 2 approving reviews are required to merge this pull request.

Assignees

@akrem-chabchoub akrem-chabchoub

Labels

None yet

Projects

None yet

Milestone

2026

Development

Successfully merging this pull request may close these issues.

File upload: auto-detect content type instead of trusting user header

2 participants

@akrem-chabchoub @acud