refactor: replace full-node flag with explicit node-mode config#5431
Draft
martinconic wants to merge 1 commit intomasterfrom
Draft
refactor: replace full-node flag with explicit node-mode config#5431martinconic wants to merge 1 commit intomasterfrom
martinconic wants to merge 1 commit intomasterfrom
Conversation
Contributor
Author
|
Beekeeper changes are also needed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Fixes #5172. The previous approach to node mode was implicit and
inconsistent: the mode was inferred from a combination of
--full-node(bool) and whether
blockchain-rpc-endpointwas non-empty, whichdiverged from the documented definition of modes and allowed silent
misconfigurations.
This PR introduces a single explicit
--node-modeoption with threevalid values:
full,light, andultra-light.Key changes:
NodeModestring type added topkg/nodewith constantsFullMode,LightMode,UltraLightMode; replacesFullNodeMode boolinOptions--node-modeflag added;--full-nodedeprecated with a warningpointing to
--node-mode=fullresolveNodeMode()instart.goenforces mode requirements at startup:fullswap-enable: true+blockchain-rpc-endpointlightblockchain-rpc-endpointultra-lightswap-enablemust be falseisChainEnabledrewritten: no longer infers chain state from the RPCendpoint string — now reads directly from
NodeModestorage-incentives-enabledefault corrected tofalse(full node only)chequebook-enabledefault corrected tofalse(requires swap-enable)bee.yaml, scoop, homebrew-amd64, homebrew-arm64)restructured into labelled mode-based sections
Test plan
node-mode: ultra-lightand no RPC — node starts cleanlynode-mode: light, no RPC — rejected with clear errornode-mode: light+ RPC — node starts in light modenode-mode: full, no RPC — rejected with clear errornode-mode: full+ RPC +swap-enable: false— rejectednode-mode: full+ RPC +swap-enable: true— full nodefull-node: true— deprecation warning, behaves asnode-mode: fullnode-mode: ultra-light+swap-enable: true— rejectedAI Disclosure