chore: enhance CI with linting and whitespace checks in GitHub Actions#579
Open
akrem-chabchoub wants to merge 2 commits intomasterfrom
Open
chore: enhance CI with linting and whitespace checks in GitHub Actions#579akrem-chabchoub wants to merge 2 commits intomasterfrom
akrem-chabchoub wants to merge 2 commits intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
Align beekeeper CI with ethersphere/bee: conventional commit lint on PRs, PR title lint, and extra quality checks (whitespace + go mod tidy). Splits lint onto Ubuntu only and keeps build/test on the OS matrix.
changes
commitlint.config.jsat repo root (@commitlint/config-conventionalrules, header max length 98).github/workflows/pr-title.yml— lint PR title onopened,synchronize,reopened,edited.github/workflows/go.yml:pull_requestwithpaths-ignore: '**/*.md'for the Go workflowlintjob: full history checkout,wagoid/commitlint-github-action@v5, golangci-lint,make vet,make check-whitespace,katexochen/go-tidy-check@v2buildjob: matrix build + test only (shallow checkout)check-whitespacetarget toMakefile(same idea as bee)why
Keeps commit and merge messages consistent across swarm repos and catches bad titles/commits before merge.
notes
LintandLint PR Titlerequired.Refs: ethersphere/bee
go.yml,pr-title.yml,commitlint.config.js.