Skip to content

feat: natural language review rules (#12) and optional skip deletion-only (#29)#44

Merged
haasonsaas merged 1 commit intomainfrom
feat/roadmap-tdd-12-29
Mar 14, 2026
Merged

feat: natural language review rules (#12) and optional skip deletion-only (#29)#44
haasonsaas merged 1 commit intomainfrom
feat/roadmap-tdd-12-29

Conversation

@haasonsaas
Copy link
Collaborator

Summary

Test plan

  • cargo test (includes new config + guidance + triage tests)
  • cargo clippy --all-targets
  • Manual: run review with review_rules_prose and triage_skip_deletion_only: true in config.

Made with Cursor

…only (#29)

- Config: review_rules_prose (YAML list), triage_skip_deletion_only (bool)
- Guidance: prose_rules_section() injects custom rules into review prompt
- Triage: TriageOptions.skip_deletion_only, SkipDeletionOnly result
- Pipeline: prepare_diff_analysis uses triage options from config
- ROADMAP: shipped section updated

Made-with: Cursor
@cursor
Copy link

cursor bot commented Mar 14, 2026

PR Summary

Medium Risk
Moderate risk because it changes review prompting and triage skip behavior, which can alter what gets sent to the LLM and potentially skip reviews for deletion-only diffs when enabled.

Overview
Adds configurable natural-language review rules via review_rules_prose, and injects them into the generated review guidance as a bullet list.

Introduces an optional triage_skip_deletion_only config flag that, when enabled, classifies deletion-only diffs as SkipDeletionOnly and skips expensive LLM review; triage is refactored to accept TriageOptions and the prepare pipeline now passes this config through. Includes new unit tests and updates the roadmap shipped section.

Written by Cursor Bugbot for commit a6d3535. This will update automatically on new commits. Configure here.

@haasonsaas haasonsaas merged commit 5af8a45 into main Mar 14, 2026
13 checks passed
@haasonsaas haasonsaas linked an issue Mar 14, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Natural language custom review rules

1 participant