feat: Add Prepend field to OnLoadResult for zero-cost text prepending#4392
Open
joelmoss wants to merge 1 commit intoevanw:mainfrom
Open
feat: Add Prepend field to OnLoadResult for zero-cost text prepending#4392joelmoss wants to merge 1 commit intoevanw:mainfrom
joelmoss wants to merge 1 commit intoevanw:mainfrom
Conversation
Add a Prepend *string field to both the public and internal OnLoadResult structs. When set, the text is prepended to the final file contents without requiring the plugin to read the file from disk. Multiple plugins can set Prepend and they concatenate in plugin order. Similar to the banner option, but it instead allows you to add a banner or other text to a file that is specific to the file. Also eliminates redundant os.ReadFile calls in plugins that only need to prepend text (like dirname), since esbuild already reads the file internally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a Prepend *string field to both the public and internal OnLoadResult structs. When set, the text is prepended to the final file contents without requiring the plugin to read the file from disk. Multiple plugins can set Prepend and they concatenate in plugin order.
Similar to the banner option, but it instead allows you to add a banner or other text to a file that is specific to the file.
Also eliminates redundant os.ReadFile calls in plugins that only need to prepend text (like dirname), since esbuild already reads the file internally.