Huawei SUN2000: support import/export for grid/battery#29790
Draft
CiNcH83 wants to merge 7 commits into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Renaming the existing
energyfields toimport/exportchanges the metric contract; consider either keeping a backward-compatibleenergyalias or explicitly handling the migration for existing consumers of this template. - The
importregister for the battery meter uses two separateifblocks forstorageunit1 and 2; if another value is passed, no address is set, so it may be safer to add anelse/default branch or validation to avoid generating an invalid configuration.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Renaming the existing `energy` fields to `import`/`export` changes the metric contract; consider either keeping a backward-compatible `energy` alias or explicitly handling the migration for existing consumers of this template.
- The `import` register for the battery meter uses two separate `if` blocks for `storageunit` 1 and 2; if another value is passed, no address is set, so it may be safer to add an `else`/default branch or validation to avoid generating an invalid configuration.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
f92fb19 to
e7a1fc0
Compare
energy=discharge returnenergy=charge
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #29805.
Notes:
Huawei does not provide self-consumption information.
Open Questions:
pv)? Is productionexport? Or do we leave it atenergy?