OCPP: don't treat SuspendedEVSE as disabled when schedule limit is set#29861
Draft
GrimmiMeloni wants to merge 1 commit into
Draft
OCPP: don't treat SuspendedEVSE as disabled when schedule limit is set#29861GrimmiMeloni wants to merge 1 commit into
GrimmiMeloni wants to merge 1 commit into
Conversation
Member
|
That would compromise compatibility with many other chargers. So I wouldn’t want to do it that way. For some boxes, |
Collaborator
Author
I had a hunch this might be the case. Assuming a charger has accepted a non-0 limit, isn't it then "enabled" in evcc's sense - independent of wether an actual charge is ongoing? |
3 tasks
Some chargers (e.g. Easee in OCPP mode) remain in SuspendedEVSE for several minutes after being enabled at minimum current before actually starting to charge. The hard-coded return false for SuspendedEVSE caused the loadpoint to detect a false "out of sync" after the 60s grace period, flipping the charger state to disabled. Remove the SuspendedEVSE short-circuit so Enabled() falls through to the schedule limit / offered measurand checks, which correctly distinguish "limit 0 = truly disabled" from "limit > 0 = enabled but waiting for EV". Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
GrimmiMeloni
force-pushed
the
fix/ocpp-suspended-evse-enabled
branch
from
9364b12 to
ff87673
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some chargers (e.g. Easee in OCPP mode) remain in SuspendedEVSE for several minutes after being enabled at minimum current before actually starting to charge. The hard-coded return false for SuspendedEVSE caused the loadpoint to detect a false "out of sync" after the 60s grace period, flipping the charger state to disabled.
Remove the SuspendedEVSE short-circuit so Enabled() falls through to the schedule limit / offered measurand checks, which correctly distinguish "limit 0 = truly disabled" from "limit > 0 = enabled but waiting for EV".