-
Notifications
You must be signed in to change notification settings - Fork 255
feat: solo sequencer, testapp max blob size ldflags #3235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
dab3be3
1fc86a5
3d84f81
77b58a6
cbfacbd
c26c090
a1c2f87
4d1b531
57cd3ef
076f094
989f43d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -11,6 +11,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||||
|
|
||||||
| ### Changes | ||||||
|
|
||||||
| - Make easier to override `DefaultMaxBlobSize` by ldflags [#3235](https://github.com/evstack/ev-node/pull/3235) | ||||||
| - Add solo sequencer (simple in memory single sequencer without force inclusion) [#3235](https://github.com/evstack/ev-node/pull/3235) | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Use hyphenated compound adjective: Minor copy fix for consistency with the rest of the docs/changelog wording. Suggested wording tweak-- Add solo sequencer (simple in memory single sequencer without force inclusion) [`#3235`](https://github.com/evstack/ev-node/pull/3235)
+- Add solo sequencer (simple in-memory single sequencer without force inclusion) [`#3235`](https://github.com/evstack/ev-node/pull/3235)📝 Committable suggestion
Suggested change
🧰 Tools🪛 LanguageTool[grammar] ~15-~15: Use a hyphen to join words. (QB_NEW_EN_HYPHEN) 🤖 Prompt for AI Agents |
||||||
| - Improve reaper to sustain txs burst better [#3236](https://github.com/evstack/ev-node/pull/3236) | ||||||
|
|
||||||
| ## v1.1.0 | ||||||
|
|
||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,21 @@ | ||
| package common | ||
|
|
||
| const DefaultMaxBlobSize = 5 * 1024 * 1024 // 5MB fallback blob size limit | ||
| import "strconv" | ||
|
|
||
| // defaultMaxBlobSizeStr holds the string representation of the default blob | ||
| // size limit. Override at link time via: | ||
| // | ||
| // go build -ldflags "-X github.com/evstack/ev-node/block/internal/common.defaultMaxBlobSizeStr=125829120" | ||
| var defaultMaxBlobSizeStr = "5242880" // 5 MB | ||
|
|
||
| // DefaultMaxBlobSize is the max blob size limit used for blob submission. | ||
| var DefaultMaxBlobSize uint64 | ||
|
|
||
| func init() { | ||
| v, err := strconv.ParseUint(defaultMaxBlobSizeStr, 10, 64) | ||
| if err != nil || v == 0 { | ||
| DefaultMaxBlobSize = 5 * 1024 * 1024 // 5 MB fallback | ||
| return | ||
| } | ||
| DefaultMaxBlobSize = v | ||
|
Comment on lines
+14
to
+20
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fail fast on an invalid Right now a malformed or zero Suggested fix-import "strconv"
+import (
+ "fmt"
+ "strconv"
+)
@@
func init() {
v, err := strconv.ParseUint(defaultMaxBlobSizeStr, 10, 64)
if err != nil || v == 0 {
- DefaultMaxBlobSize = 5 * 1024 * 1024 // 5 MB fallback
- return
+ panic(fmt.Sprintf("invalid defaultMaxBlobSizeStr %q: expected a non-zero base-10 uint64", defaultMaxBlobSizeStr))
}
DefaultMaxBlobSize = v
}As per coding guidelines, "Validate all inputs from external sources in Go code". 🤖 Prompt for AI Agents |
||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix grammatical issue: missing subject pronoun.
The phrase "Make easier to override" is grammatically incomplete. Add "it" or restructure for clarity.
📝 Suggested wording fix
📝 Committable suggestion
🤖 Prompt for AI Agents