Skip to content

chore: prep v1.1.0#3237

Merged
julienrbrt merged 2 commits intomainfrom
julien/110
Apr 9, 2026
Merged

chore: prep v1.1.0#3237
julienrbrt merged 2 commits intomainfrom
julien/110

Conversation

@julienrbrt
Copy link
Copy Markdown
Member

@julienrbrt julienrbrt commented Apr 9, 2026

Prep v1.1.0

Summary by CodeRabbit

  • Chores

    • Updated core dependencies to stable v1.1.0 across application modules.
  • Documentation

    • Cleaned up CHANGELOG: formatting tweaks, removed template/placeholder sections, and added an Unreleased note referencing v1.1.0.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 9, 2026

📝 Walkthrough

Walkthrough

Updated github.com/evstack/ev-node dependency from v1.1.0-rc.2 to v1.1.0 across multiple Go modules and edited CHANGELOG.md: added a v1.1.0 entry, converted several * bullets to -, and removed commented template sections leaving only the [Unreleased] link.

Changes

Cohort / File(s) Summary
Changelog Documentation
CHANGELOG.md
Added v1.1.0 subsection, changed leading bullets from * to - (including nested lists), and removed large commented template/guideline sections, leaving only the [Unreleased] compare link.
Go Module Dependencies
apps/evm/go.mod, apps/grpc/go.mod, apps/testapp/go.mod, tools/da-debug/go.mod
Bumped direct dependency github.com/evstack/ev-node from v1.1.0-rc.2 to v1.1.0 in each module's require block; no other dependency or replace entries changed.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • tac0turtle
  • randygrok

Poem

🐰 A hop, a bump, the versions sing,
From RC doubt to stable ring.
Changelog cleared, four modules aligned,
Small edits tidy, release defined. ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description 'Prep v1.1.0' is minimal and lacks required context. The template requires an 'Overview' section with explanation, background, goal, rationale, and issue links, none of which are provided. Expand the description to include an overview section explaining the changes, rationale for updating to v1.1.0, and any relevant issue numbers or links as specified in the template.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'chore: prep v1.1.0' clearly and concisely summarizes the main purpose of the PR, which is preparing the release of version 1.1.0 across all modules.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch julien/110

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 9, 2026

The latest Buf updates on your PR. Results from workflow CI / buf-check (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed⏩ skipped✅ passed✅ passedApr 9, 2026, 12:35 PM

@claude
Copy link
Copy Markdown
Contributor

claude bot commented Apr 9, 2026

Claude finished @julienrbrt's task in 1m 16s —— View job


Code Review: chore: prep v1.1.0

  • Gather context
  • Review CHANGELOG.md
  • Review go.mod files
  • Post findings

This is a straightforward release preparation PR with a few issues worth addressing.

apps/grpc/go.mod — Active replace Directives (Bug)

apps/grpc/go.mod lines 5–8 still have active replace directives pointing to local source:

replace (
    github.com/evstack/ev-node => ../../
    github.com/evstack/ev-node/execution/grpc => ../../execution/grpc
)

Meanwhile, apps/evm/go.mod has the equivalent replace block commented out. With the replace directive active, the apps/grpc module will resolve github.com/evstack/ev-node from the local ../../ path rather than the published v1.1.0 tag — making the version bump in the require block meaningless for that module. These directives should be commented out (or removed) before release, consistent with apps/evm.

Fix this →

CHANGELOG.md — Stale [Unreleased] Comparison Link

The footer link at line 257 still targets v1.0.0-beta.1:

[Unreleased]: https://github.com/evstack/ev-node/compare/v1.0.0-beta.1...HEAD

For a v1.1.0 release this should be updated to compare from v1.1.0, and a [v1.1.0] comparison link should be added per the Keep a Changelog convention:

[Unreleased]: https://github.com/evstack/ev-node/compare/v1.1.0...HEAD
[v1.1.0]: https://github.com/evstack/ev-node/compare/v1.1.0-rc.2...v1.1.0

Fix this →

Minor Observations

  • The v1.1.0 section header uses bare text (## v1.1.0) while [Unreleased] uses brackets with a link ref. The Keep a Changelog format expects linked version headers like ## [v1.1.0]. Not a blocker but worth making consistent.
  • The CodeRabbit-flagged typo (v1.0.0-rc.2v1.1.0-rc.2) and empty bullet issue are both correctly addressed in commit 27c8407.
  • The bulk bullet-point reformatting (*-) is stylistically fine; - is canonical in most Markdown linters.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@CHANGELOG.md`:
- Around line 339-342: Remove the lone hyphen that creates an empty bullet under
the "Links" section in the changelog: delete the standalone "-" line immediately
after the "<!-- Links -->" comment so the section has no empty list item.
- Around line 12-15: The CHANGELOG entry for "## v1.1.0" incorrectly states "No
changes from v1.0.0-rc.2"; update that reference to the correct release
candidate (replace v1.0.0-rc.2 with v1.1.0-rc.2) so the v1.1.0 entry correctly
reflects it is unchanged from v1.1.0-rc.2; edit the "## v1.1.0" line in
CHANGELOG.md accordingly.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: cc60a192-2a5e-4978-9837-fd98b2aa8463

📥 Commits

Reviewing files that changed from the base of the PR and between 6f09600 and b80b8b4.

⛔ Files ignored due to path filters (3)
  • apps/evm/go.sum is excluded by !**/*.sum
  • apps/testapp/go.sum is excluded by !**/*.sum
  • tools/da-debug/go.sum is excluded by !**/*.sum
📒 Files selected for processing (5)
  • CHANGELOG.md
  • apps/evm/go.mod
  • apps/grpc/go.mod
  • apps/testapp/go.mod
  • tools/da-debug/go.mod

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.67%. Comparing base (6f09600) to head (27c8407).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3237   +/-   ##
=======================================
  Coverage   61.67%   61.67%           
=======================================
  Files         120      120           
  Lines       12635    12635           
=======================================
  Hits         7793     7793           
  Misses       3968     3968           
  Partials      874      874           
Flag Coverage Δ
combined 61.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@CHANGELOG.md`:
- Line 35: Update the CHANGELOG entry that currently uses "[3209](...)" to match
the repository's changelog label style by changing the link text to
"[`#3209`](...)" so it is consistent with other entries; locate the line
containing "Bound Badger index cache memory to prevent growth with chain length
[3209](...)" and replace the bracketed label only.
- Line 56: Replace the incorrect phrase "Two different sort of pruning
implemented" with grammatically correct wording such as "Two different types of
pruning implemented" or "Two different sorts of pruning have been implemented"
in the CHANGELOG entry; locate the exact string "Two different sort of pruning
implemented" and update it to one of these suggested alternatives so the release
note reads clearly and correctly.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d10b4af5-1c75-4b11-b893-91293f17ec5a

📥 Commits

Reviewing files that changed from the base of the PR and between b80b8b4 and 27c8407.

📒 Files selected for processing (1)
  • CHANGELOG.md

Copy link
Copy Markdown
Contributor

@chatton chatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@julienrbrt julienrbrt merged commit dea4af1 into main Apr 9, 2026
31 of 32 checks passed
@julienrbrt julienrbrt deleted the julien/110 branch April 9, 2026 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants