🐛 FIX: i18n of buttons#175
Closed
TheTripleV wants to merge 1 commit into
Closed
Conversation
|
Thanks for submitting your first pull request! You are awesome! 🤗 |
TheTripleV
commented
Dec 29, 2023
Author
I fixed translations but broke button links somehow.
|
24 tasks
Member
|
Thanks @TheTripleV for digging into this back in 2023 — you had the right diagnosis (gettext targeting the whole directive rather than the button text) well before anyone else picked it up. Closing in favour of #264, which takes the same direction and adds Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #96 .
closes #44 ?
cc wpilibsuite/frc-docs-translations#38