✨ FontAwesome v6 roles, CDN config, fontawesome5 LaTeX support#285
Open
chrisjsewell wants to merge 1 commit into
Open
✨ FontAwesome v6 roles, CDN config, fontawesome5 LaTeX support#285chrisjsewell wants to merge 1 commit into
chrisjsewell wants to merge 1 commit into
Conversation
7c47e9f to
d53f19b
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #285 +/- ##
==========================================
+ Coverage 90.72% 91.44% +0.72%
==========================================
Files 13 13
Lines 1207 1251 +44
==========================================
+ Hits 1095 1144 +49
+ Misses 112 107 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
- add v6 roles fa-solid/fa-brands/fa-regular (legacy fa/fas/fab/far kept)
- add sd_fontawesome_source ("none"|"cdn") and sd_fontawesome_cdn_url config
- sd_fontawesome_latex now accepts "none"/"fontawesome"/"fontawesome5"
(bool True/False still work identically); "fontawesome5" emits \faIcon{...}
- throttle the LaTeX / unsupported-builder icon warnings to once per build
Closes #174, #242.
d53f19b to
2c7a2d2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modernizes the FontAwesome integration around three declarative config options.
Changes
fa-solid/fa-brands/fa-regular, emitting exactly those classes. The legacyfa/fas/fab/farroles are unchanged (and documented as legacy). This is the supported path for FontAwesome Pro kits (FontAwesome import interfering with Pro License #174): load your kit, use v6 names.sd_fontawesome_source("none"default /"cdn") +sd_fontawesome_cdn_url: opt-in CDN loading viaapp.add_css_file, replacing the docs' copy-pastehtml_css_filesinstruction. The docs now dogfood it.sd_fontawesome_latexgrows string values while keepingTrue/Falseworking (True≡"fontawesome", output verified byte-identical to main):"fontawesome5"loadsfontawesome5.styand emits\faIcon{name}/\faIcon[regular]{name}(brands resolve by bare name — mapping independently verified against the package's completion data). This resolves the Latex build broken in Sphinx 8 #242 class of clash: if your theme loadsfontawesome5, set the same value so both agree. The stored value stays raw (TOML-round-trippable); normalization is a computed property.once=True, verified on the 7.2 floor).Verification
rebuild="env"); absolute CDN URLs are emitted verbatim (no?v=mangling, no copy attempt) on 7.2.6 and 9.x; epub with"cdn"behaves identically to the pre-existinghtml_css_filesapproach;bool|strconfval type-checking clean across the range; no duplicate CDN link in the dogfooding docs build.sd_fontawesome_latex = Trueproduces the same\usepackage{fontawesome}+\faicon{...}output as main.tests/test_fontawesome.pycovers roles, CDN link exactly-once/absent, both LaTeX packages, and once-per-build warnings.Closes #174
Closes #242