📚 Clarify that buttons are styled links#287
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #287 +/- ##
=======================================
Coverage 92.63% 92.63%
=======================================
Files 13 13
Lines 1371 1371
=======================================
Hits 1270 1270
Misses 101 101
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Carried from PR #158, updated for the current docs: explains that button-link/button-ref render as styled <a> tags (not <button>), when to prefer plain link syntax, and the accessibility implications.
chrisjsewell
force-pushed
the
docs/button-links-intro
branch
from
f82e96f to
1ae7382
Compare
This was referenced Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Carries the documentation clarification from #158 (thanks @gabalafou — the commit is authored to you) forward onto the current docs:
button-link/button-refare links styled as buttons, and that plain link syntax is usually the right tool — these directives are for calling visual attention to a link.<a>tag, not<button>, so assistive tech treats them as links (e.g. they appear in links lists).The original PR's snippet/fixture additions are not carried: they predate three rewrites of this docs page and the button test-suite additions (#281's
tests/test_buttons.pynow coversbutton-refrendering directly), so only the prose — the durable part — comes forward, lightly adapted.Supersedes #158 (will be closed with credit once this merges).