Skip to content

Sync simple cipher#1025

Open
Narkunan wants to merge 9 commits into
exercism:mainfrom
Narkunan:sync-simple-cipher
Open

Sync simple cipher#1025
Narkunan wants to merge 9 commits into
exercism:mainfrom
Narkunan:sync-simple-cipher

Conversation

@Narkunan

@Narkunan Narkunan commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

Fix issue #987

@github-actions

github-actions Bot commented Jul 12, 2026

Copy link
Copy Markdown

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@resu-xuniL resu-xuniL mentioned this pull request Jul 12, 2026
Open
mk-mxp
mk-mxp reviewed Jul 13, 2026
View reviewed changes

@mk-mxp mk-mxp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for helping! Please go through all UUID comments and adjust them as stated below.

Looking forward to the next iteration!

Comment thread exercises/practice/simple-cipher/.meta/config.json
Comment thread exercises/practice/simple-cipher/SimpleCipherTest.php Outdated
Comment thread exercises/practice/simple-cipher/SimpleCipherTest.php Outdated
Comment thread exercises/practice/simple-cipher/SimpleCipherTest.php Outdated
Comment thread exercises/practice/simple-cipher/SimpleCipherTest.php Outdated
Comment thread exercises/practice/simple-cipher/SimpleCipherTest.php Outdated
Comment thread exercises/practice/simple-cipher/SimpleCipherTest.php Outdated
@mk-mxp mk-mxp added x:action/sync Sync content with its latest version x:knowledge/elementary Little Exercism knowledge required x:module/practice-exercise Work on Practice Exercises x:type/content Work on content (e.g. exercises, concepts) x:size/small Small amount of work x:rep/small Small amount of reputation labels Jul 13, 2026
@Narkunan

Narkunan commented Jul 18, 2026

Copy link
Copy Markdown
Contributor Author

@mk-mxp Sorry, Can't address it quickly. Please Rereview ready for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mk-mxp mk-mxp mk-mxp left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@Narkunan Narkunan

Labels

x:action/sync Sync content with its latest version x:knowledge/elementary Little Exercism knowledge required x:module/practice-exercise Work on Practice Exercises x:rep/small Small amount of reputation x:size/small Small amount of work x:type/content Work on content (e.g. exercises, concepts)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Narkunan @mk-mxp