feat(metadata): Warn on unknown previews; clear old previews#3603
Draft
feat(metadata): Warn on unknown previews; clear old previews#3603
Conversation
Validate preview types and improve cleanup to avoid Apple limits. - In PreviewsTask.uploadAsync, skip unknown preview types and emit warnings. If the type uses an APP_ prefix and the stripped type is valid, suggest the corrected type. Also log the list of valid preview types. - In syncPreviewSetAsync, delete all existing previews before uploading the new one to avoid "Too many app previews" errors (Apple limits each set to 3 previews). - Add tests covering APP_ prefix suggestion and fully unknown preview types, and mock the Log module in tests.
Add two bugfix entries for eas-cli (PR #3603): warn and skip unknown preview types in `metadata:push` with a suggestion for mistaken `APP_` screenshot prefixes, and delete existing previews in a preview set before uploading to avoid Apple's "Too many app previews" error. Credits to @EvanBacon.
|
✅ Thank you for adding the changelog entry! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validate preview types and improve cleanup to avoid Apple limits.