Upgrade content-disposition#7233
Open
blakeembrey wants to merge 2 commits into
Open
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
blakeembrey
commented
May 11, 2026
| // set Content-Disposition when file is sent | ||
| var headers = { | ||
| 'Content-Disposition': contentDisposition(name || path) | ||
| 'Content-Disposition': contentDisposition.create(name || basename(path)) |
Member
Author
There was a problem hiding this comment.
The correct backward compatibility would be basename(name || path), should I do that instead? The difference is if someone gave a path instead of a filename in the filename parameter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version 2 upgrade will mostly only be relevant for users that want to generate non-ASCII by ISO-8859-1 valid filenames. There was a gap in theoretical vs real behavior of browsers that sniffed this and failed to have the correct encoding for filenames because it treated them as UTF-8 instead. See jshttp/content-disposition#27 for more information.
Separately, the API no longer attempts to
basenameinputs so I need to do that in the Express API instead.