fix(view): avoid opaque TypeError for view names ending in "." - #7393
Open
Errr0rr404 wants to merge 1 commit into
Open
fix(view): avoid opaque TypeError for view names ending in "."#7393Errr0rr404 wants to merge 1 commit into
Errr0rr404 wants to merge 1 commit into
Conversation
path.extname('index.') returns '.', so the engine loader called
require('') and threw ERR_INVALID_ARG_VALUE before lookup could fail
cleanly. Skip loading when the extension body is empty so app.render
returns the usual "Failed to lookup view" error instead.
Fixes expressjs#7350
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
path.extname('index.')returns'.', so the view engine loader calledrequire('')and threwERR_INVALID_ARG_VALUEbefore lookup could fail cleanly.app.renderreturns the usualFailed to lookup viewerror.Fixes #7350
Test plan
"."yields helpful lookup error