Don't crash on front matter with non-string mapping keys - #133
Open
eeshsaxena wants to merge 1 commit into
Open
Conversation
loads did Post(content, handler, **metadata), which raises 'keywords must be strings' when the parsed metadata has non-string keys. Integers, booleans and dates are all valid YAML/TOML mapping keys, so a document like '---\n1: one\n---' blew up even though the front matter is valid. Assign the metadata dict to the Post directly instead of splatting it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
frontmatter.loadscrashes on a document whose front matter has a non-string key:Integers, booleans and dates are all valid YAML (and TOML) mapping keys, but
loadsbuilds the post withPost(content, handler, **metadata), and splatting a dict with a non-string key into keyword arguments raisesTypeError: keywords must be strings, even though the front matter itself parsed fine.The fix assigns the parsed metadata dict to the
Postdirectly instead of splatting it, so non-string keys are preserved and round-trip throughdumps/loads. String-key documents are unaffected. Added a test.