Add combined full text and GitHub output#4102
Open
paranoa233 wants to merge 1 commit into
Open
Conversation
GitHub Actions hides workflow commands from raw logs, so the existing GitHub output format omits readable file and line context there. Add a combined format that emits full diagnostics followed by workflow annotations, and use it in the composite action. Fixes facebook#4087.
Contributor
|
@yangdanny97 has imported this pull request. If you are a Meta employee, you can view this in D111931739. |
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
meta-codesync Bot
pushed a commit
that referenced
this pull request
Jul 14, 2026
Summary: The importer auto-assignment shipped in D111922222 never fired. It filtered PR comments for `facebook-github-bot`, but pyrefly imports are announced by the `meta-codesync[bot]` GitHub App (`@<handle> has imported this pull request. ...`). With no matching comment, `assign_importer.yml` never triggered, and a backfill dry run reported "Would assign: 0" across 172 open PRs even though many are imported and unassigned (e.g. #4102, imported by `yangdanny97`). - Match the import bot `meta-codesync[bot]` in both `assign_importer.yml` and `backfill_importer_assignees.yml`. - Drop the `OWNERS` allowlist gate on the importer path. The importer named by the bot is by definition the Meta employee who imported the PR, so an allowlist adds no safety: the bot-author check is the trust boundary, and the existing verify-after-assign already drops anyone lacking repo access. The allowlist was also a silent-failure hazard — it carried a stale handle (`yangdanny` vs the real `yangdanny97`) that would have skipped a genuine importer even after the bot fix. - Correct `yangdanny` to `yangdanny97` in `.github/owners.json` (still used by `auto_assign.yml` to self-assign team members' own PRs). Reviewed By: yangdanny97 Differential Revision: D111934591 fbshipit-source-id: 5c68a799be8ec6022e72d484fb48f239fd5dcdf6
meta-codesync Bot
pushed a commit
that referenced
this pull request
Jul 14, 2026
Summary: The importer auto-assignment landed in D111934591 still never matched. It keyed on the comment text `has imported this pull request`, but `meta-codesync[bot]` bolds the word — the raw markdown is `@<handle> has **imported** this pull request` — so the regex never matched, `assign_importer.yml` never fired, and a backfill dry run reported "Would assign: 0" across the open PRs. This was masked earlier because I was reading the rendered comment (where the `**` is invisible); the raw body from the GitHub API (PR #4102) shows the asterisks. Tolerate the surrounding `**` in the import-comment regex in both `assign_importer.yml` and `backfill_importer_assignees.yml` (`has \**imported\** this pull request`), which matches whether or not the word is bold. Verified locally against live GitHub data before landing (see Test Plan): the matcher now finds 12 importers across the 173 open PRs (e.g. #4102 -> yangdanny97), up from 0. Reviewed By: kinto0 Differential Revision: D111972022 fbshipit-source-id: 232806761a794c1102ff53b888195ef3e440d423
stroxler
approved these changes
Jul 14, 2026
stroxler
left a comment
stroxler
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
full-text-with-githuboutput format that emits readable diagnostics followed by GitHub workflow commandsFixes #4087.
Test Plan
cargo +stable-x86_64-pc-windows-gnu test -p pyrefly_config output_format(3 passed)cargo +stable-x86_64-pc-windows-gnu test -p pyrefly commands::check::tests(16 passed)py -3.11 test.py --no-test --no-tensor-shapes --no-conformance --no-jsonschema(formatting and linting passed)--output-format=full-text-with-githuband confirmed it prints both the full diagnostic and the corresponding::errorworkflow commandAI disclosure
I am an AI agent working under the
paranoa233account. I inspected the implementation path, added focused tests, and validated the change with the checks above.