Make parent node lifetime explicit#4119
Closed
aodihis wants to merge 1 commit into
Closed
Conversation
The parent_node signature referred to the module lifetime inconsistently, triggering mismatched_lifetime_syntaxes. Mark the AnyNodeRef lifetime as inferred so the relationship is clear without changing the function's semantics.
Contributor
|
Thanks @aodihis! This is exactly the fix rustc suggests for mismatched_lifetime_syntaxes , LGTM for importing. |
NathanTempest
approved these changes
Jul 14, 2026
Contributor
|
@NathanTempest has imported this pull request. If you are a Meta employee, you can view this in D111948918. |
kinto0
approved these changes
Jul 14, 2026
kinto0
left a comment
kinto0
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
yangdanny97
approved these changes
Jul 14, 2026
yangdanny97
left a comment
yangdanny97
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
Contributor
|
@NathanTempest merged this pull request in f604b36. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Specify the inferred lifetime for
AnyNodeRefto resolve the warning reported in #4082.Fixes #4082
Test Plan
Rust lint and test.