Keep public re-exports from excluded files in pyrefly coverage --public-only#4133
Closed
jorenham wants to merge 1 commit into
Closed
Keep public re-exports from excluded files in pyrefly coverage --public-only#4133jorenham wants to merge 1 commit into
pyrefly coverage --public-only#4133jorenham wants to merge 1 commit into
Conversation
jorenham
changed the title
pyrefly coverage --public-onlypyrefly coverage --public-only
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Contributor
|
@kinto0 has imported this pull request. If you are a Meta employee, you can view this in D111949706. |
yangdanny97
approved these changes
Jul 14, 2026
yangdanny97
left a comment
yangdanny97
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--project-excludesis applied at file discovery, so an excluded module never produced a report, even when a non-excluded public module re-exports from it.pyrefly coverage {check, report} --public-onlynow collects such re-export origins in a second pass, so a symbol is only excluded when all of its public re-export locations are excluded.Fixes #4034
Alternative to #4048
Test Plan
Regression tests added, and verified that this does not change any of the results for
scipy-stubsandnumpy.