Print config warnings in pyrefly coverage#4149
Open
jorenham wants to merge 1 commit into
Open
Conversation
This comment has been minimized.
This comment has been minimized.
jorenham
force-pushed
the
coverage/emit-config-warnings
branch
from
b406d0b to
273d59b
Compare
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Config warnings are printed when using
pyrefly check(e.g. invalidsite-package-path), but thepyrefly coveragecommands didn't. So now they do :)Spotted while working on #4146.
Test Plan
Scrut test added, and manually verified that
pyrefly coverage report's stdout stays valid json.