fix(stubgen): regenerate type_checking_or_guard snapshot for Literal import#4173
Closed
samwgoldman wants to merge 1 commit into
Closed
fix(stubgen): regenerate type_checking_or_guard snapshot for Literal import#4173samwgoldman wants to merge 1 commit into
samwgoldman wants to merge 1 commit into
Conversation
…import #4144 made stubgen emit `from typing import Literal` whenever it adds a `Literal[...]` annotation, but the `type_checking_or_guard` fixture was not regenerated. Its `expected.pyi` used `Literal[True]` without importing `Literal` (an invalid stub), so the snapshot test panicked on trunk. Update the fixture to the now-correct output, which includes the emitted `from typing import Literal`, keeping the `# @generated` header used by the other fixtures. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
|
@samwgoldman has imported this pull request. If you are a Meta employee, you can view this in D112434885. |
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
kinto0
approved these changes
Jul 16, 2026
kinto0
left a comment
kinto0
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
Contributor
|
@samwgoldman merged this pull request in 2935171. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
stubgen::tests::test_stubgen_type_checking_or_guardpanics onmain. Thetype_checking_or_guardsnapshot referencedLiteral[True]without importingLiteral(an invalid stub). Once #4144 made stubgen emitfrom typing import Literalwhen it adds aLiteral[...]annotation, this fixture went stale and the snapshot assertion started failing.Fix
Regenerate the
type_checking_or_guardexpected.pyito include the now-emittedfrom typing import Literal, keeping the# @generatedheader used by the other fixtures. This is a pure test-fixture update — no stubgen logic change.Testing
cargo test --lib -p pyrefly stubgen::→ all 24 stubgen tests pass (was 1 failing).🤖 Generated with Claude Code