feat: adopt AGP v9 by hurali97 · Pull Request #57038 · facebook/react-native

hurali97 · 2026-06-02T08:11:50Z

Summary:

This PR is part of Android Gradle Plugin v9 adoption. With this PR, we adopt the AGP9 repository wide and address the deprecated APIs with the newer ones.

This is in combination with #57038

Changes to `configureBuildConfigFieldsForLibraries` and `configureNamespaceForLibraries`

These helpers are called from `ReactPlugin.apply`, but they currently iterate over `rootProject.allprojects`. Since `com.facebook.react` is applied by multiple Android library projects, each application of the plugin repeats the same traversal and attempts to register `finalizeDsl` callbacks for every Android library project.

The first traversal can register the callbacks successfully. However, a later traversal can reach a project whose Android DSL finalization phase has already completed. Starting with AGP 9, AGP explicitly errors when finalizeDsl is called after that phase has passed, which causes the build failure. see

To understand this, consider following modules:

:react-native-safe-area-context
:react-native-mmkv
:react-native-skia

The current code on main, would result in executing the following block 3 times:

  fun configureBuildConfigFieldsForLibraries(appProject: Project) {
    appProject.rootProject.allprojects { subproject ->
      println("=== subproject ${subproject.name}")
      subproject.pluginManager.withPlugin("com.android.library") {
        subproject.extensions
            .getByType(LibraryAndroidComponentsExtension::class.java)
            .finalizeDsl { ext -> ext.buildFeatures.buildConfig = true }
      }
   }
}

The output would be:

> Configure project: react-native-safe-area-context
=== subproject RNProject
=== subproject app
=== subproject react-native-safe-area-context
=== subproject react-native-mmkv
=== subproject react-native-skia

> Configure project: react-native-mmkv
=== subproject RNProject
=== subproject app
=== subproject react-native-safe-area-context
=== subproject react-native-mmkv
=== subproject react-native-skia

> Configure project: react-native-skia
=== subproject RNProject
=== subproject app
=== subproject react-native-safe-area-context
=== subproject react-native-mmkv
=== subproject react-native-skia

Now with AGP9, the same code will throw this error:

> Configure project: react-native-safe-area-context
=== subproject RNProject
=== subproject app
=== subproject react-native-safe-area-context
=== subproject react-native-mmkv
=== subproject react-native-skia

> Configure project: react-native-mmkv
=== subproject RNProject
=== subproject app
=== subproject react-native-safe-area-context
=== subproject react-native-mmkv

* What went wrong:
A problem occurred evaluating project': react-native-mmkv'.
> Failed to apply plugin
'com. facebook. react'
> It is too late to call
finalizeDst
as the DSL finalization
blocks have already been executed. \n
In particular, you cannot call 'finalizeDsl' within the "beforeVariants' or "onVariants' blocks.
Instead, you must call finalizeDsl' directly within the
"androidComponents' block

Solution:

Since these helpers are only intended to configure Android library projects that apply the React plugin, we can configure the current project inside pluginManager.withPlugin("com.android.library") instead of repeatedly configuring all projects from every plugin application.

 fun configureBuildConfigFieldsForLibraries(project: Project) {
    project.extensions
      .getByType(LibraryAndroidComponentsExtension::class.java)
      .finalizeDsl { ext ->
        ext.buildFeatures.buildConfig = true
      }
    }

  fun configureNamespaceForLibraries(project: Project) {
    project.extensions
      .getByType(LibraryAndroidComponentsExtension::class.java)
      .finalizeDsl { ext ->
        if (ext.namespace == null) {
          val manifestFile =
            project.layout.projectDirectory.file("src/main/AndroidManifest.xml").asFile
          manifestFile
            .takeIf { it.exists() }
            ?.let { file ->
              getPackageNameFromManifest(file)?.let { packageName ->
                ext.namespace = packageName
              }
            }
        }
      }
    }

One important note for configureNamespaceForLibraries is that the old com.android.build.gradle.LibraryExtension is deprecated in favor of com.android.build.api.dsl.LibraryExtension - which does not expose manifestFile from the sourceSets. So we have to define a path for it. For most libraries, this should be OK but for the ones which define custom path, this will fail.

Hence, I believe, if it's important to have this fallback, we take this tradeoff. Otherwise, since there has been 2 years passed for AGP8 adoption and the time when this fallback was added, we may safely remove this function as almost all libraries now define a namespace in android { } DSL.

With the above in place, we make one final change and that is to move these two functions inside the withPlugin("com.android.library") as these are only intended for libraries and that way, we also ensure that these will only be applied once the com.android.library plugin has been applied.

    project.pluginManager.withPlugin("com.android.library") {
      configureBuildConfigFieldsForLibraries(project)
      configureNamespaceForLibraries(project)
      configureCodegen(project, extension, rootExtension, isLibrary = true)
    }

Changelog:

[ANDROID] [BREAKING] - Adopt AGP v9

Test Plan:

CI passes
Verified on RN Tester
Verified on Local RN App

rn-tester.mp4

hurali97 · 2026-06-03T08:55:50Z

 androidx-appcompat = { module = "androidx.appcompat:appcompat", version.ref = "androidx-appcompat" }
 androidx-appcompat-resources = { module = "androidx.appcompat:appcompat-resources", version.ref = "androidx-appcompat" }
 androidx-autofill = { module = "androidx.autofill:autofill", version.ref = "androidx-autofill" }
+androidx-collection = { module = "androidx.collection:collection", version.ref = "androidx-collection" }


This is required for ReactAndroid to compile successfully. If not provided, we face the following error:

cortinico

Thanks for taking a stab at this @hurali97 !

cortinico · 2026-06-03T15:41:06Z

+tasks.withType<JavaCompile>().configureEach {
+  exclude("com/facebook/react/processing/**")
+  exclude("com/facebook/react/module/processing/**")
+}


Why this? This should not be necessary at all

I think it is required with AGP9 as we face the following error that states unavailability of excludes filter. I believe this happened as part of: https://issuetracker.google.com/issues/368609737

Ah I see. You can remove those as those folders no longer exist

cortinico · 2026-06-03T15:41:37Z

-# Those 2 properties are needed to make our project compatible with
-# AGP 9.0.0 for the time being. Ideally we should not opt-out of
-# builtInKotlin and newDsl once AGP 9.0.0 hits stable.
-# More on this: https://developer.android.com/build/releases/agp-preview#android-gradle-plugin-built-in-kotlin
-android.builtInKotlin=false
-android.newDsl=false


Are we good removing those?

I believe so. After removing those and bumping to AGP v9.2.1 - there were build issues that have already been fixed as part of this PR, so we should be good.

cortinico · 2026-06-05T09:46:55Z

+tasks.withType<JavaCompile>().configureEach {
+  exclude("com/facebook/react/processing/**")
+  exclude("com/facebook/react/module/processing/**")
+}


Ah I see. You can remove those as those folders no longer exist

cortinico · 2026-06-05T09:47:08Z

-# Those 2 properties are needed to make our project compatible with
-# AGP 9.0.0 for the time being. Ideally we should not opt-out of
-# builtInKotlin and newDsl once AGP 9.0.0 hits stable.
-# More on this: https://developer.android.com/build/releases/agp-preview#android-gradle-plugin-built-in-kotlin
-android.builtInKotlin=false
-android.newDsl=false


hurali97 · 2026-06-05T10:51:56Z

+android.builtInKotlin=false
+android.newDsl=false


Enabling the opt-outs for hello-world to match the behavior of template

hurali97 · 2026-06-05T11:58:45Z

The failing runs for community template:

Should be fixed once react-native-community/template#224 is merged

meta-codesync · 2026-06-05T14:05:34Z

@cortinico has imported this pull request. If you are a Meta employee, you can view this in D107656378.

meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 2, 2026

hurali97 mentioned this pull request Jun 2, 2026

feat: enable opt outs for AGP v9 react-native-community/template#224

Open

hurali97 commented Jun 3, 2026

View reviewed changes

hurali97 changed the title ~~Bump to agp9~~ feat: adopt AGP v9 Jun 3, 2026

hurali97 marked this pull request as ready for review June 3, 2026 11:16

facebook-github-tools Bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Jun 3, 2026

cortinico requested changes Jun 3, 2026

View reviewed changes

hurali97 added 6 commits June 5, 2026 11:21

chore: bump agp to 9.2.1

87d49e2

feat: use agp9 for core

74bfd7f

feat: replace deprecated APIs

2367bc6

fix: comment out the fallbacks

24e305f

fix: deprecated APIs

3b3e2a3

fix: use androidx.collection with implementation

305b41a

hurali97 force-pushed the bump-to-agp9 branch from 312a317 to 305b41a Compare June 5, 2026 06:49

cortinico approved these changes Jun 5, 2026

View reviewed changes

hurali97 added 2 commits June 5, 2026 15:44

refactor: unnecessary pattern filter

e895962

feat: enable opt outs in helloworld template

440e25d

hurali97 commented Jun 5, 2026

View reviewed changes

		android.builtInKotlin=false
		android.newDsl=false No newline at end of file

Conversation

hurali97 commented Jun 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary:

Changelog:

Test Plan:

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cortinico left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hurali97 commented Jun 5, 2026

Uh oh!

meta-codesync Bot commented Jun 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

hurali97 commented Jun 2, 2026 •

edited

Loading