Fix Hermes compiler detection for monorepos#57086
Open
ya-nsh wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Hermes compiler autodetection for Android apps whose Gradle project root is nested below the workspace root, such as monorepos with hoisted
node_modules.The Gradle plugin already exposes
reactNativeDir, but Hermes autodetection only looked underreact.root. That means release bundling can fail even when bothreactNativeDirand the hoistedhermes-compilerpackage are correctly installed and resolvable from the configured React Native package directory.This change:
reactNativeDirinto Hermes compiler detectionhermes-compilerpackage next to the configured React Native package directoryreact.hermesCommandand project-local Hermes precedencenode_modules/react-native/sdks/hermesc/%OS-BIN%/hermescwith the actual checked locationsCloses #55673
Closes #54944
Test plan
Changelog:
[ANDROID] [FIXED] - Fix Hermes compiler autodetection for monorepos with hoisted node_modules