Fix text decoration color fallback to use per-span foreground color#57087
Open
cortinico wants to merge 1 commit into
Open
Fix text decoration color fallback to use per-span foreground color#57087cortinico wants to merge 1 commit into
cortinico wants to merge 1 commit into
Conversation
Summary: D104680895 introduced custom decoration drawing that falls back to `layout.paint.color` when `textDecorationColor` is not set. This is the base paint color (typically black), not the actual foreground color of the text span. For text with `ForegroundColorSpan` (e.g., link text with teal color, white text on dark backgrounds), the decoration was drawn in the wrong color. Fix: when `textDecorationColor` is TRANSPARENT (default), look up the `ForegroundColorSpan` at the decoration start position and use its color instead. Changelog: [Android][Fixed] - Fix text decoration color not matching foreground color when `textDecorationColor` is not set Differential Revision: D107645191
meta-cla
Bot
added
the
CLA Signed
|
@cortinico has exported this pull request. If you are a Meta employee, you can view the originating Diff in D107645191. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
D104680895 introduced custom decoration drawing that falls back to
layout.paint.colorwhentextDecorationColoris not set. This is the base paint color (typically black), not the actual foreground color of the text span. For text withForegroundColorSpan(e.g., link text with teal color, white text on dark backgrounds), the decoration was drawn in the wrong color.Fix: when
textDecorationColoris TRANSPARENT (default), look up theForegroundColorSpanat the decoration start position and use its color instead.Changelog: [Android][Fixed] - Fix text decoration color not matching foreground color when
textDecorationColoris not setDifferential Revision: D107645191