Skip to content

Fix Perfetto TraceSection integratiuon on APPLE and delete unused ReactPerfettoLogger const (#57091) #57091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
christophpurrer wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −2
Open

Fix Perfetto TraceSection integratiuon on APPLE and delete unused ReactPerfettoLogger const (#57091) #57091

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-native/ReactCommon/cxxreact/TraceSection.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ using TraceSectionUnwrapped = DummyTraceSection;
* In the case of WITH_LOOM_TRACE we don't use the signposts APIs because of the
* templated type for TraceSection.
*/
#if defined(__APPLE__) && OS_LOG_TARGET_HAS_10_15_FEATURES && !defined(WITH_LOOM_TRACE)
#if defined(__APPLE__) && OS_LOG_TARGET_HAS_10_15_FEATURES && !defined(WITH_LOOM_TRACE) && !defined(WITH_PERFETTO)

namespace systrace {

Expand Down
1 change: 0 additions & 1 deletion packages/react-native/ReactCommon/reactperflogger/reactperflogger/ReactPerfettoLogger.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ namespace {
#if defined(WITH_PERFETTO)
const HighResTimeStamp PROGRAM_INIT_TIME = HighResTimeStamp::now();
const std::string PERFETTO_DEFAULT_TRACK_NAME = "# Web Performance";
const std::string PERFETTO_TRACK_NAME_PREFIX = "# Web Performance: ";

std::string toPerfettoTrackName(
const std::optional<std::string_view>& trackName,
Expand Down
Loading