Skip to content

[DevTools] Fix XSS in standalone onError via innerHTML #36431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tomohiro86 wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −3
Open

[DevTools] Fix XSS in standalone onError via innerHTML #36431

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions packages/react-devtools-core/src/standalone.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,11 +195,14 @@ function onError({code, message}: $FlowFixMe) {
<div class="box-header">
Unknown error
</div>
<div class="box-content">
${message}
</div>
<div class="box-content"></div>
</div>
`;
// Use textContent to avoid XSS from error message strings.
const contentNode = node.querySelector('.box-content');
if (contentNode !== null) {
contentNode.textContent = message;
}
}
}

Expand Down
Loading