Skip to content

Fix custom module preload resource tracking #36441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
afurm wants to merge 1 commit into
base: main
Choose a base branch
from
+21 −1
Open

Fix custom module preload resource tracking #36441

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-dom-bindings/src/server/ReactFizzConfigDOM.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6552,7 +6552,7 @@ function preloadModule(
resumableState.moduleUnknownResources.hasOwnProperty(as);
let resources;
if (hasAsType) {
resources = resumableState.unknownResources[as];
resources = resumableState.moduleUnknownResources[as];
if (resources.hasOwnProperty(key)) {
// we can return if we already have this resource
return;
Expand Down
20 changes: 20 additions & 0 deletions packages/react-dom/src/__tests__/ReactDOMFloat-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6532,6 +6532,26 @@ body {
);
});

it('preloads multiple modules with the same custom as value', async () => {
function App() {
ReactDOM.preloadModule('worker-a', {as: 'serviceworker'});
ReactDOM.preloadModule('worker-b', {as: 'serviceworker'});
return <div>hello</div>;
}

await act(() => {
renderToPipeableStream(<App />).pipe(writable);
});

expect(getMeaningfulChildren(document.body)).toEqual(
<div id="container">
<link rel="modulepreload" href="worker-a" as="serviceworker" />
<link rel="modulepreload" href="worker-b" as="serviceworker" />
<div>hello</div>
</div>,
);
});

it('warns if you provide invalid arguments', async () => {
function App() {
ReactDOM.preloadModule();
Expand Down