Skip to content

fix[devtools]: gracefully handle missing nodes in TREE_OPERATION_REMOVE instead of crashing #36475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MD-Mushfiqur123 wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −10
Open

fix[devtools]: gracefully handle missing nodes in TREE_OPERATION_REMOVE instead of crashing #36475

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions packages/react-devtools-shared/src/devtools/store.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1611,13 +1611,13 @@ export default class Store extends EventEmitter<{
const element = this._idToElement.get(id);

if (element === undefined) {
this._throwAndEmitError(
Error(
if (__DEBUG__) {
console.warn(
`Cannot remove node "${id}" because no matching node was found in the Store.`,
),
);
);
}

break;
continue;
}

i += 1;
Expand Down Expand Up @@ -1649,13 +1649,13 @@ export default class Store extends EventEmitter<{

parentElement = this._idToElement.get(parentID);
if (parentElement === undefined) {
this._throwAndEmitError(
Error(
if (__DEBUG__) {
console.warn(
`Cannot remove node "${id}" from parent "${parentID}" because no matching node was found in the Store.`,
),
);
);
}

break;
continue;
}

const index = parentElement.children.indexOf(id);
Expand Down