refactor(writer): Clean up writer performance stats#802
Open
HuamengJiang wants to merge 1 commit into
Open
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@HuamengJiang has exported this pull request. If you are a Meta employee, you can view the originating Diff in D106909562. |
Summary: Follow-up cleanup for D106147104. Addresses review comments from xiaoxmeng. - Remove `totalFlushTiming_` / `stripeFlushTiming_` — `encodingTiming` subsumes flush timing - Write I/O uses `NanosecondTimer` (wall-only) since CPU time is not meaningful for I/O; remove `writeCpuTimeNs` - Replace `folly::StreamingStats<uint64_t>` with `velox::RuntimeMetric` for `chunkSizeStats` in `FieldWriterContext` and `VeloxWriter::Stats` - Replace `std::vector<uint64_t> rowsPerStripe` with `velox::RuntimeMetric` in `VeloxWriter::Stats` - Remove `inputBufferReallocCount` / `inputBufferReallocItemCount` from `Stats` - Move chunk size and `rowsPerStripe` reporting from `customStats_` to `addThreadLocalRuntimeStat` - Fix `FileWriter.cpp` `ws_pwrite` latency to use `writeWallTimeNs` instead of encoding timing - Rename `writerStats` to `stats` in `NimbleWriter.cpp` Differential Revision: D106909562
HuamengJiang
force-pushed
the
export-D106909562
branch
from
78ccf84 to
e15dd7b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Follow-up cleanup for D106147104. Addresses review comments from xiaoxmeng.
totalFlushTiming_/stripeFlushTiming_—encodingTimingsubsumes flush timingNanosecondTimer(wall-only) since CPU time is not meaningful for I/O; removewriteCpuTimeNsfolly::StreamingStats<uint64_t>withvelox::RuntimeMetricforchunkSizeStatsinFieldWriterContextandVeloxWriter::Statsstd::vector<uint64_t> rowsPerStripewithvelox::RuntimeMetricinVeloxWriter::StatsinputBufferReallocCount/inputBufferReallocItemCountfromStatsrowsPerStripereporting fromcustomStats_toaddThreadLocalRuntimeStatFileWriter.cppws_pwritelatency to usewriteWallTimeNsinstead of encoding timingwriterStatstostatsinNimbleWriter.cppDifferential Revision: D106909562