Randomize specs#182
Merged
etagwerker merged 1 commit intomainfrom May 4, 2026
Merged
Conversation
etagwerker
approved these changes
May 4, 2026
Member
etagwerker
left a comment
etagwerker
left a comment
There was a problem hiding this comment.
@arielj Looks good, thanks!
etagwerker
approved these changes
May 4, 2026
Member
etagwerker
left a comment
etagwerker
left a comment
There was a problem hiding this comment.
@arielj Looks good, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR enables a random order and fixes a test that was order-dependant.
Motivation and Context
While trying to debug the issue with the Ruby 2.3 tests sometimes failing, I noticed that we are not running tests with random order which is a common good practice to avoid order-dependent tests.
The updated test was sometimes failing because the NextRails class was memoizing the value and if the other tests ran before the first test, the memozied value was wrong. We have to reset the memoized value before every test to avoid issues.
How Has This Been Tested?
Running the tests locally many many times. Confirming with the output that the order is not static.
I will abide by the code of conduct