Fix Ruff DTZ rules after update - #699
Open
santisoler wants to merge 3 commits into
Open
Conversation
Specify the timezone when calling `datetime` functions, to avoid naive objects that are not time-zone aware.
Make sure to compute seconds from last epoch by setting the start of the year in UTC time.
Parametrize igrf tests using `tzinfo` as UTC or None. Add extra tests to check that some of the fixes work as expected.
Member
Author
|
@leouieda would you mind double checking these changes? Particularly the change to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address Ruff's DTZ rules by specifying the timezone when calling
datetimefunctions. This fix extends the support of the IGRF classes to dates with timezone information. When interpolating the IGRF coefficients set the start of the year to the UTC time of January 1st at 00:00. Add ignore comments where thetzinfois not relevant. Add some tests to the IGRF functions that cover dates with and without information about the timezone.Leaving link to those rules for reference: https://docs.astral.sh/ruff/rules/#flake8-datetimez-dtz