Add HDF5 dependency to dev containers#88
Conversation
📝 WalkthroughWalkthroughBoth Dockerfile configurations now include a new build stage for HDF5 library compilation and installation. A versioned build argument Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@docker/alma10/Dockerfile`:
- Around line 106-120: The Dockerfile currently builds and installs HDF5 from
source (ARG HDF5_VERSION / RUN git clone ... && cmake ... --install to
/usr/local) while the Alma image also installs the distro hdf5-devel package,
causing duplicate headers/libraries; pick one approach and remove the other:
either delete this source-build RUN block (lines that clone hdf5_src, configure
and install to /usr/local) and rely on the distro hdf5-devel package, or remove
hdf5-devel from root_dependencies.txt and keep the source build (ensuring
CMAKE_INSTALL_PREFIX=/usr/local remains intentional); make the change so only
one HDF5 stack is installed and update any README or build comments to reflect
the chosen path.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 960882ef-38ec-487c-9a51-f836e1344850
📒 Files selected for processing (2)
docker/alma10/Dockerfiledocker/ubuntu24/Dockerfile
Codecov Report✅ All modified and coverable lines are covered by tests. |
|
For some very strange reason, this PR was merged to main but the commit does not appear in the main branch... Re-trying again in #89 |
This PR installs the HDF5 dependency in the docker containers, which is required in preparation for #84
Summary by CodeRabbit