remove lxml#7090
Merged
Merged
Conversation
cnlucas
requested review from
johnnyporkchops,
patphongs and
rfultz
and removed request for
johnnyporkchops,
patphongs and
rfultz
patphongs
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary (required)
This removes lxml as I don't think we are currently using it. Wagtail used to use it a long time ago, and it was brought in here to support scrapers which I don't think we use anymore:
fec-cms/fec/search/management/commands/scrape_cms_pages.py
fec-cms/fec/search/management/commands/scrape_transition_pages.py
fec-cms/fec/search/management/commands/scrape_web_app_pages.py
fec-cms/fec/search/utils/search_indexing.py
Required reviewers
1-2 dev
How to test
activate your current CMS virtualenv and confirm snyk vulnerability
snyk test --file=requirements.txt
pull this branch:
gh pr checkout 7090pip install -r requirements.txt
pip install -r requirements.txt
rm -rf node_modules
npm i && run build
run snyk test --file=requirements.txt (confirm vulnerability is removed)
pytest
cd fec && ./manage.py runserver
Or rebuild this on stage and double check searching:
https://app.circleci.com/pipelines/github/fecgov/fec-cms/4806/workflows/3576821e-07da-4379-9abb-969e0918e7df/jobs/8392