Add SolidStart integration and refactor fedify init internals#652
Open
2chanhaeng wants to merge 24 commits intofedify-dev:mainfrom
Open
Add SolidStart integration and refactor fedify init internals#6522chanhaeng wants to merge 24 commits intofedify-dev:mainfrom
fedify init internals#6522chanhaeng wants to merge 24 commits intofedify-dev:mainfrom
Conversation
issues-auto-labeler
bot
added
component/build
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the @fedify/solidstart package for SolidStart integration, providing a new middleware, comprehensive documentation, and an example project. Significant refactoring was performed on the @fedify/init package to centralize dependency versions in JSON files and migrate command execution to the dax library. Feedback highlights the need to update CHANGES.md with missing bug fixes and proper contributor credit, ensure consistency in middleware implementation examples, and move hardcoded dependency versions in the new SolidStart integration logic to the centralized configuration.
Extract the Fedify middleware for SolidStart into a dedicated package (@fedify/solidstart), providing a fedifyMiddleware() helper that handles ActivityPub content negotiation with SolidStart's middleware system. Uses a WeakMap<Request, Response> internally for 406 response storage, so users don't need to declare App.RequestEventLocals. Update the example to use the new package instead of inline middleware. fedify-dev#476 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add a SolidStart section to docs/manual/integration.md with installation instructions, app.config.ts setup, and middleware usage example. Add @fedify/solidstart changelog entry under Version 2.1.0, and update packages/fedify/README.md with JSR link for the new package. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add SolidStart as a web framework option in the `fedify init` command, allowing users to scaffold new Fedify+SolidStart projects. All boilerplate files (app config, middleware, routes, entry points) are provided as templates since no suitable degit template exists for SolidStart. The lookup test skips the solidstart+deno combination because Deno's `links` feature does not populate `node_modules/`, which Vite (used by vinxi) requires for SSR module resolution. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Deno import maps use exact string matching, so the base "@solidjs/start" entry does not resolve subpath specifiers like "@solidjs/start/config" or "@solidjs/start/server". This adds explicit mappings for all subpaths used by the generated template files and @fedify/solidstart. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Consolidate lookup-test-only exclusions into a single pattern-based rule table so framework-wide and combination-specific bans follow the same matching logic. This keeps the supported-option checks unchanged while making the temporary lookup exclusions easier to maintain. Add regression tests for lookup case parsing and wildcard-based filtering. Co-Authored-By: OpenAI Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
@fedify/solidstartpackage for SolidStart integration and overhaulfedify initinternals: centralize dependency versions, replacerunSubCommandwith@david/dax, and improve test infrastructure.Related issue
test-init#591fedify initdependency versions #637Changes
packages/solidstart: Addpackages/solidstart/providingfedifyMiddleware()for SolidStart's middleware system. (by @dodok8)packages/init:scripts/update_init_deps.tsto auto-update dependency versions.runSubCommandwith@david/dax.mise test:init.packages/express: Fix bug by replacingreq.hostwithreq.header("Host").packages/astro: Fix bug by adding--no-installfor non-Deno package managers.docs: Add docs about SolidStart integration. (by @dodok8)examples/solidstart: Add an example app using SolidStart integration. (by @dodok8)Benefits
fedify inittemplates are now centralizedand auto-updatable, reducing manual maintenance.
runSubCommandwith@david/daxsimplifies subprocesshandling and removes custom error classes.
running multiple test apps sequentially.
Additional notes
req.host→req.header("Host")) isindependent of SolidStart but was discovered during integration
testing.