Code Quality: Replace OneWay with OneTime in Command bindings#18682
Draft
Lamparter wants to merge 3 commits into
Draft
Code Quality: Replace OneWay with OneTime in Command bindings#18682Lamparter wants to merge 3 commits into
Command bindings#18682Lamparter wants to merge 3 commits into
Conversation
Lamparter
force-pushed
the
onetime/Command
branch
from
8532371 to
53ef860
Compare
0x5bfa
suggested changes
Jul 6, 2026
0x5bfa
left a comment
0x5bfa
left a comment
Member
There was a problem hiding this comment.
OneTime should be omitted since it's the default for x:Bind.
Lamparter
force-pushed
the
onetime/Command
branch
from
49ac1b7 to
dcfa9b0
Compare
Member
|
You can revert as Yair requests, then I can approve. |
This reverts commit dcfa9b0.
Lamparter
force-pushed
the
onetime/Command
branch
from
1c9177d to
388bd59
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
Code quality issues are now discussed on Discord.
Steps used to test these changes