fix(auth): make AuthException messages customisable via AuthUIStringProvider#2320
Open
demolaf wants to merge 2 commits into
Open
fix(auth): make AuthException messages customisable via AuthUIStringProvider#2320demolaf wants to merge 2 commits into
demolaf wants to merge 2 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request enables custom error message mapping in AuthException by integrating the AuthUIStringProvider. The changes include updating the AuthException.from factory method to accept a string provider, adding new error message properties to the AuthUIStringProvider interface, and updating various UI screens and providers to pass the context or string provider during exception handling. Feedback focuses on correcting a regression in fallback error messages for disabled users, ensuring consistent precedence where the custom provider overrides SDK messages, and utilizing the local stringProvider in UI screens instead of the context overload to prevent ignoring user-configured custom providers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1815 —
AuthExceptionmessages were hardcoded in English with noway for apps to customise or translate them.
From strings.xml in consumers app
Expected Behavior