Skip to content

fix(ui_auth): widen app_links constraint to allow 7.x - #676

Open
bjrochem72 wants to merge 1 commit into
firebase:mainfrom
bjrochem72:widen-app-links-constraint
Open

fix(ui_auth): widen app_links constraint to allow 7.x#676
bjrochem72 wants to merge 1 commit into
firebase:mainfrom
bjrochem72:widen-app-links-constraint

Conversation

@bjrochem72

Copy link
Copy Markdown

Description

firebase_ui_auth currently pins app_links: ^6.4.0. On iOS, the app_links 6.x line still registers through the deprecated UIApplicationDelegate lifecycle events, so every app depending on firebase_ui_auth sees an AppLinksIosPlugin deprecation warning in the launch console. app_links 7.x adopts the UIScene lifecycle and clears it.

This PR widens the constraint to ">=6.4.0 <8.0.0":

  • Projects on recent Flutter resolve app_links 7.x and the warning disappears.
  • Projects on older Flutter keep resolving 6.x (app_links 7.0.0 requires Flutter 3.38.1+), so no minimum-version bump is needed on firebase_ui_auth's side.

No code changes are required: this package's use of the app_links API is limited to the AppLinks() constructor and uriLinkStream (email_link_auth_provider.dart, email_verification.dart), both unchanged in 7.x — the app_links 7.0.0 changelog explicitly notes it remains backward compatible with v6 setups.

Verified locally with app_links 7.2.1 resolved in the workspace:

  • dart analyze packages — no issues across all packages
  • firebase_ui_auth unit tests — 69/69 passing
  • firebase_ui_oauth unit tests — 7/7 passing

Related Issues

Fixes #672

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (constraint-only change, no behavioral change; existing tests cover the affected surface).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///) — not applicable, no code changes.
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • All unit tests pass (melos run test:unit:all doesn't fail).
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@google-cla

google-cla Bot commented Aug 1, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the dependency constraint for app_links in packages/firebase_ui_auth/pubspec.yaml from ^6.4.0 to ">=6.4.0 <8.0.0" to expand compatibility. There are no review comments, and I have no feedback to provide.

@bjrochem72

Copy link
Copy Markdown
Author

@googlebot I signed it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

firebase_ui_auth: widen app_links constraint to allow ^7.0.0

1 participant