fix(ui_auth): widen app_links constraint to allow 7.x - #676
Open
bjrochem72 wants to merge 1 commit into
Open
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
@googlebot I signed it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
firebase_ui_authcurrently pinsapp_links: ^6.4.0. On iOS, the app_links 6.x line still registers through the deprecated UIApplicationDelegate lifecycle events, so every app depending onfirebase_ui_authsees anAppLinksIosPlugindeprecation warning in the launch console. app_links 7.x adopts the UIScene lifecycle and clears it.This PR widens the constraint to
">=6.4.0 <8.0.0":firebase_ui_auth's side.No code changes are required: this package's use of the app_links API is limited to the
AppLinks()constructor anduriLinkStream(email_link_auth_provider.dart,email_verification.dart), both unchanged in 7.x — the app_links 7.0.0 changelog explicitly notes it remains backward compatible with v6 setups.Verified locally with app_links 7.2.1 resolved in the workspace:
dart analyze packages— no issues across all packagesfirebase_ui_authunit tests — 69/69 passingfirebase_ui_oauthunit tests — 7/7 passingRelated Issues
Fixes #672
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///) — not applicable, no code changes.melos run analyze) does not report any problems on my PR.melos run test:unit:alldoesn't fail).Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?