fix(functions): store CLOUD_TASKS_EMULATOR_HOST at construction time#3167
Open
jonathanedey wants to merge 2 commits into
Open
fix(functions): store CLOUD_TASKS_EMULATOR_HOST at construction time#3167jonathanedey wants to merge 2 commits into
CLOUD_TASKS_EMULATOR_HOST at construction time#3167jonathanedey wants to merge 2 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the FunctionsApiClient to cache the CLOUD_TASKS_EMULATOR_HOST environment variable at construction time rather than reading it dynamically from process.env during execution. This cached value is then propagated to FunctionsHttpClient and helper functions, and corresponding unit tests have been added and updated. The feedback suggests improving the robustness of the environment variable parsing by trimming whitespace and treating empty strings as undefined, as well as simplifying the unit tests by utilizing a single stub with sequential call assertions instead of manual stub restoration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Historically,
CLOUD_TASKS_EMULATOR_HOSTwas read fromprocess.envon every individual API call. This made it impossible to safely run one Firebase app pointing to the local emulator and another pointing to a real project concurrently.This pull request resolves the issue by caching the value of
CLOUD_TASKS_EMULATOR_HOSTonce when theFunctionsApiClientis constructed. The configuration is stored per-instance, ensuring that each client retains its own independent emulator setup.Based on a patch contribution #3059 (comment)