feat(auth): Update ActionCodeSettings to support link_domain and deprecate dynamic_link_domain#884
Conversation
|
@lahirumaramba @pashanka see here re: #883. In my org we're currently relying on this via a fork and would be great to get into main release. |
Xiaoshouzi-gh
left a comment
Xiaoshouzi-gh
left a comment
There was a problem hiding this comment.
Thanks for putting this together!
Xiaoshouzi-gh
left a comment
Xiaoshouzi-gh
left a comment
There was a problem hiding this comment.
Thank you for putting this together!
huwmartin
force-pushed
the
action-code-settings-link-domain
branch
from
1d9d933 to
dfce7c1
Compare
jonathanedey
left a comment
jonathanedey
left a comment
There was a problem hiding this comment.
Thanks @huwmartin for putting this together! Overall LGTM with one minor change below.
jonathanedey
requested review from
egilmorez
and removed request for
OrlandriaH-G
jonathanedey
left a comment
jonathanedey
left a comment
There was a problem hiding this comment.
LGTM! Please address the lint error and update the branch, Thanks!
|
@jonathanedey thanks, lots of other issues when running |
|
@huwmartin, no worries, those were mainly because the branch was out of date. We made some lint changes in or last release and the CI here are using those settings. Thanks again for you contribution! |
jonathanedey
changed the title
ActionCodeSettings to support link_domain and deprecate dynamic_link_domain
jonathanedey
changed the title
ActionCodeSettings to support link_domain and deprecate dynamic_link_domainActionCodeSettings to support link_domain and deprecate dynamic_link_domain
…eprecate `dynamic_link_domain` (#884) * Add link_domain to ActionCodeSettings; update encode_action_code_settings to handle link_domain * Add handling for InvalidHostingLinkDomainError * Add deprecation warning for dynamic_link_domain * Update error message for InvalidHostingLinkDomainError * Fix lint * Add type hints to ActionCodeSettings * Fix f-string lint
6 participants
Discussion
Firebase Dynamic Links will stop working August 25th 2025.
Migration instructions indicate that to use a custom domain one should update usage of
ActionCodeSettingsto uselinkDomain, see also in the Firebase Admin docs.We currently depend upon
generate_sign_in_with_email_linkto generate email links,firebase-admin-pythonhasn't been updated withlink_domainand currently only supportsdynamic_link_domain,firebase-admin-nodehas been updated with support forlinkDomainso I assume this should be officially supported, please let me know if this is not the case.See #883.
This PR updates
ActionCodeSettingsto acceptlink_domainand updatesencode_action_code_settingsto handlelink_domainwhen constructing request payload. I have also added definition for newInvalidHostingLinkDomainErrorerror.