Upgrade mocha and @types/mocha to latest compatible versions#323
Open
inlined wants to merge 3 commits into
Open
Upgrade mocha and @types/mocha to latest compatible versions#323inlined wants to merge 3 commits into
inlined wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security Audit & Remediation: firebase-functions-test (Mocha Upgrade)
A. Previous CVEs
minimatchviamocha(Severity: High)minimatchviamocha(Severity: High)minimatchviamocha(Severity: High)minimatchviamocha(Severity: High)js-yamlviamocha(Severity: Moderate)js-yamlviamocha(Severity: Moderate)diffviamocha(Severity: Low)debugviamocha(Severity: Low)B. Changes Made
mochafrom^6.2.2to latest major version^11.7.6and@types/mochafrom^5.2.7to^10.0.10inpackage.jsondevDependencies.firebase-functions-testpackage.jsonengines which already enforce Node>=20.0.0.npm testrunningmocha .tmp/spec/index.spec.jsandnpm run integrationTestrunningmocha .tmp/spec/integration/**/*.spec.js) are fully compatible with Mocha v11 programmatic and CLI execution APIs.minimatch <= 3.0.4,js-yaml <= 3.13.1,diff <= 3.5.0,debug <= 2.6.9, legacymkdirp).C. Remaining CVEs
firebase-tools,firebase-admin, andtslint(addressed in companion security audit PRs).D. Introduced CVEs
E. Testing Strategy
npm test) -> 118 passing tests (100% pass rate).npm run lint) -> 0 errors.