fix(firebase_messaging): migrate example iOS project from ObjC to Swift#18317
fix(firebase_messaging): migrate example iOS project from ObjC to Swift#18317champ96k wants to merge 3 commits into
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request migrates the iOS example app runner from Objective-C to Swift, replacing the legacy AppDelegate.h, AppDelegate.m, and main.m files with AppDelegate.swift and SceneDelegate.swift, and updating the Xcode project configuration accordingly. The review feedback suggests removing the redundant application(_:didFinishLaunchingWithOptions:) override in AppDelegate.swift to reduce boilerplate code, as it only forwards the call to its superclass.
|
Hi @champ96k, could you resolve the CI issues? |
- Add SceneDelegate.swift to license header ignore list in melos.yaml - Format SceneDelegate.swift with swiftformat
|
@SelaseKay Done please check and let me know, Thanks |
| --ignore "**/Runner/AppDelegate.h" \ | ||
| --ignore "**/Runner/AppDelegate.m" \ | ||
| --ignore "**/Runner/main.m" \ | ||
| --ignore "**/Runner/SceneDelegate.swift" \ |
There was a problem hiding this comment.
This should be removed as well.
There was a problem hiding this comment.
@champ96k, kindly remove all references to SceneDelegate.swift.
… references - Remove redundant application(_:didFinishLaunchingWithOptions:) from AppDelegate.swift - Delete SceneDelegate.swift file (FlutterSceneDelegate used directly in Info.plist) - Remove --ignore SceneDelegate.swift entries from melos.yaml - Remove SceneDelegate.swift references from project.pbxproj - Revert Info.plist to use FlutterSceneDelegate directly
|
Hi @SelaseKay , all comments have been addressed:
Please take another look! |
2 participants
Description:
Updates the firebase_messaging example iOS project from the old Objective-C template to the modern Swift template, matching what
flutter creategenerates today.Changes
AppDelegate.h,AppDelegate.m,main.m(Objective-C)AppDelegate.swiftwith@main+FlutterImplicitEngineDelegateSceneDelegate.swift(emptyFlutterSceneDelegatesubclass)Runner-Bridging-Header.hInfo.plist— scene delegate class uses$(PRODUCT_MODULE_NAME).SceneDelegateproject.pbxproj— replaced ObjC file refs with Swift, addedSWIFT_VERSION = 5.0,SWIFT_OBJC_BRIDGING_HEADER,CLANG_ENABLE_MODULESChecklist
Related Issues:
Fixes #13059
Breaking Change:
No, this is not a breaking change.