Implement CI tests for FIPS-mode 6.1 guest kernels#5888
Open
deRemo wants to merge 2 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5888 +/- ##
=======================================
Coverage 82.91% 82.91%
=======================================
Files 277 277
Lines 30077 30077
=======================================
Hits 24937 24937
Misses 5140 5140
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
deRemo
force-pushed
the
fips
branch
4 times, most recently
from
d363c5e to
a1ed0a3
Compare
deRemo
added
the
Status: Awaiting review
deRemo
force-pushed
the
fips
branch
5 times, most recently
from
6d1dfa4 to
392ee0f
Compare
Adapt the test framework to support FIPS-mode guest kernels. When FIPS is enabled, the kernel restricts available crypto algorithms, which breaks the default SSH connection setup. This pins FIPS-approved key exchange, host key, and cipher algorithms in the SSH client configuration. Signed-off-by: Riccardo Mancini <mancio@amazon.com>
Add integration tests that verify correct FIPS behavior across snapshot restore. The tests confirm that the kernel boots into FIPS mode, that the expected reseed log message appears after restoring a snapshot, and that both kernel and userspace CSPRNGs produce divergent output on two VMs restored from the same snapshot. This ensures cloned VMs do not share random state, which is a critical security property. Supporting changes include new test fixtures for booting and snapshotting a FIPS VM, pinning PubkeyAcceptedAlgorithms for SSH compatibility, and using explicit RSA-2048 key generation in CI setup. Signed-off-by: Remo Andreoli <andrremo@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Enable FIPS-mode testing for 6.1 guest kernels. This includes:
Test infrastructure changes to support FIPS testing:
KexAlgorithms=ecdh-sha2-nistp521, HostKeyAlgorithms=rsa-sha2-512, PubkeyAcceptedAlgorithms=rsa-sha2-512, cipheraes256-ctr) to the SSH connection helperuvm_with_fipsandfips_snapshot_pairfixtures intests/conftest.pyFIPS integration testsuite to verify:
/dev/urandom) diverges across two VMs restored from the same snapshotsecretsmodule) diverges across two VMs restored from the same snapshotReason
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkbuild --allto verify that the PR passesbuild checks on all supported architectures.
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.