fix(cli): restore authenticated MCP launch flow - #182
Merged
Conversation
hmishra2250
marked this pull request as ready for review
August 7, 2026 08:28
hmishra2250
requested review from
developersdigest and
rakshith48
and removed request for
developersdigest and
rakshith48
August 7, 2026 08:28
There was a problem hiding this comment.
All reported issues were addressed across 7 files
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the MCP launch regression introduced by credential hardening:
firecrawl init -k <key>stored a credential thatfirecrawl launch <agent>subsequently refused because the MCP installer only recognizedprocess.env.firecrawl launch${FIRECRAWL_API_KEY}or the client-native equivalent)npx, client setup argv, or client config--install/--config/--setup--keylesssetup and launch flags1.19.30Authentication behavior
launch <agent>with stored key/v2/mcpwith an env reference and gives the key only to the launched agentFIRECRAWL_API_KEY--keyless/v2/mcpwithout an Authorization headerSecurity verification
Executed the original reproduction with isolated credentials and instrumented client shims:
Bearer ${FIRECRAWL_API_KEY}, never the literal keynpxinstaller did not receiveFIRECRAWL_API_KEYAlso exercised the built CLI across Claude Code, VS Code, Codex, Codex App, OpenCode, Hermes, and OpenClaw, plus keyless
--agent all.Verification
pnpm run format:checkpnpm run type-checkpnpm run buildpnpm run test(417/417)Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Restores authenticated MCP launch by keeping configs env-referenced and scoping a stored API key to the launched agent’s environment. Adds explicit
--keylesssetup/launch and unifies Hermes/OpenClaw under a sharedinstallMcp.Bug Fixes
firecrawl init -kcreated a key thatfirecrawl launchrejected; the key now goes only to the child process env.${FIRECRAWL_API_KEY}or client-native); the literal key is never written to config,npx, or setup argv.--keylesswith--skip-mcp.1.19.30.New Features
--keylesstosetupandlaunchfor explicit anonymous MCP.installMcp; both honor keyless and env indirection.Written for commit 4a79128. Summary will update on new commits.