Skip to content

fix(search): expose pretty JSON option - #183

Open
ayushcodes13 wants to merge 1 commit into
firecrawl:mainfrom
ayushcodes13:fix/181-search-pretty-option
Open

fix(search): expose pretty JSON option#183
ayushcodes13 wants to merge 1 commit into
firecrawl:mainfrom
ayushcodes13:fix/181-search-pretty-option

Conversation

@ayushcodes13

@ayushcodes13 ayushcodes13 commented Aug 10, 2026

Copy link
Copy Markdown

Summary

  • restore the -p, --pretty option registration for firecrawl search
  • keep the existing search output behavior where pretty implies JSON output
  • add CLI argv coverage so firecrawl search --help exposes --pretty

Closes #181

Test Plan

  • pnpm run build
  • pnpm vitest run src/__tests__/cli-argv.test.ts src/__tests__/commands/search.test.ts
  • pnpm run format:check

The new CLI argv test failed before the option registration was restored because search help did not include --pretty; it passes after the change.


Summary by cubic

Fixes #181 by restoring the -p, --pretty flag for firecrawl search to enable pretty-printed JSON and show it in --help. Preserves behavior where --pretty implies JSON and adds a CLI argv test to prevent regressions.

Written for commit 4d18d6f. Summary will update on new commits.

Review in cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Re-trigger cubic

@ayushcodes13
ayushcodes13 force-pushed the fix/181-search-pretty-option branch from 421b2e7 to 4d18d6f Compare August 10, 2026 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(search): documented --pretty option is rejected

1 participant