Enable setting the base for a PR using labels#5121
Conversation
Helpful for multi-PR changes.
| on: | ||
| pull_request: | ||
| types: [ opened, synchronize, reopened, labeled ] | ||
| types: [ opened, synchronize, reopened, labeled, unlabeled ] |
There was a problem hiding this comment.
Why do we need this now but we didn't before?
There was a problem hiding this comment.
I want the workflow to be triggered whenever the labels change, not just when a new label is added. I ran into this because I was switching out the labels to test this and found that it wasn't being rerun as expected.
|
Just to check that I understand. Is this for the case where I have this branch structure: and I have a PR to merge Currently we look at the target branch to determine whether to build firedrake using Is that correct? |
Yep spot on. |
This PR lets us set the base branch to
mainorrelease(and therefore use a dev/release build) using labels. This is useful for cases where you have dependent PRs and therefore the base branch may not bemainorrelease.