[Deploy] Comparison reports#6012
Draft
mstange wants to merge 42 commits into
Draft
Conversation
mstange
force-pushed
the
comparison-reports
branch
2 times, most recently
from
a3cc414 to
4bd0212
Compare
It's not used by any TreeView users yet. The next commit will use it for the marker table. The intention is to also use it for the function list.
The sort is also persisted in the URL.
lint fix
…ings
- Fix wrong tab slug ('calltree' → 'function-list') in _onEnterOrDoubleClick
for SelfWing, UpperWingFlameGraph, LowerWing, and UpperWing so that
double-clicking a call node opens the bottom box for the correct tab
- Add a contextMenuId prop to FlameGraph (defaulting to 'CallNodeContextMenu')
so wings can specify a different context menu
- Wire up FunctionListContextMenu for UpperWingFlameGraph and SelfWing:
right-clicking now dispatches changeRightClickedFunctionIndex so the
FunctionListContextMenu (already rendered in Details) can respond
This is a workaround for Firefox and Chrome using different syntax to indicate the location of a JS function. On Windows, the difference is samply's fault: The JIT ETW events already allow specifying the URL and line/col separately from the function name, but samply puts it back into the function name. And Firefox doesn't make use of those ETW events yet.
The tooltip uses `position: fixed` which interprets `left/top` as viewport-relative, but `ChartCanvas` was storing `event.pageX/pageY` (document-relative, including scroll offsets). In a non-scrolling page these match, but inside a scrollable container like our benchmark page they diverge by `window.scrollY`, dragging the tooltip down. Switched the state field from `pageX/pageY` to `clientX/clientY`.
…amples of that subtest
mstange
force-pushed
the
comparison-reports
branch
from
b345b45 to
0c8885a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.